fix: CI test failure — TempDir cleanup race in process test#17
Merged
Conversation
TestProcessTopByCPU_SortRegression spawns a goroutine that writes to
TempDir after 1ms. On Go 1.25+ t.TempDir() cleanup is strict and fails
if the directory is not empty. The goroutine could still be writing
when cleanup starts.
Fix: t.Cleanup(func() { <-done }) ensures goroutine finishes before
TempDir removal.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TestProcessTopByCPU_SortRegressionfails on Go 1.25+ CI:A goroutine writes to TempDir after 1ms delay. Go 1.25 made
t.TempDir()cleanup stricter — it now fails the test if removal fails. The goroutine could still be writing when cleanup starts.Fix
Ensures goroutine finishes before TempDir removal. Verified: 5/5 passes locally.
🤖 Generated with Claude Code